Add review page accordions #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Date picker now accepts a string MM/DD/YYYY and spits out the same * Each page defines sections that are used in the review accordion * Simplified how the activity report imports the pages for the report
Conflicts: .circleci/config.yml package.json src/routes/apiDirectory.js
Add review page accordions
Rename `admin/user` route to `admin/users`
rahearn
requested changes
Jan 5, 2021
| * @param {*} res - response | ||
| */ | ||
| export async function submitReport(req, res) { | ||
| // Temporary until submitting of report is implemented |
There was a problem hiding this comment.
Just putting a pin in that we will need to add authorization to this route when it is implemented.
| Please review all information in each section before submitting to your manager for | ||
| approval. | ||
| </p> | ||
| <MultiSelect |
There was a problem hiding this comment.
I can't figure out why - but when I run this locally it has a weird default value on the approvers list.
There was a problem hiding this comment.
I left in some old data simulating loading managers/additional notes from an already saved report. I'll remove the old data.
| title: 'Resources', | ||
| anchor: 'resources', | ||
| items: [ | ||
| { label: 'Resources used', name: 'resources used', path: 'name' }, |
There was a problem hiding this comment.
The URL resources don't appear in the review page.
* The url resource now shows up in activity reports review page * Add openapi route for the `approvers` endpoint. Held off on adding a route for submit until it is fully implemented * Removed old fake data from the review page (additional notes and approving managers are now blank) * Removed dumbeldore as an approver as he has no "name". Added another approver to the fake data
Update user auto inc in seeder
review page feedback
rahearn
pushed a commit
that referenced
this pull request
Mar 22, 2021
Display external link warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The review page now has an accordion with an item for each page that matches the desired design. The report still needs to be marked as
Submittedin the backend after saving of a report (#98) is closed.How to test
Dev:
Test on https://tta-smarthub-dev.app.cloud.gov/activity-reports/review. Note I haven't tested on DEV yet because I can't login to the UAT environment. I didn't want to wait for UAT to work before getting eyes on this PR.
Local:
Issue(s)
Checklist