Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Personal Health Record (SPHR) - First Attempt #1090

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

awatson1978
Copy link
Contributor

  • First attempt at defining JIRA Spec Artifacts to enable SPHR for balloting.
  • Was not able to find the .buildLocal.bat file.
  • Did my best to follow all other instructions.

Copy link
Collaborator

@lmckenzi lmckenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the version 0.4.6? Typically the first version should be 1.0.0-ballot. (I.e. first ballot leading to a planned 1.0.0 release)

Your publication request should indicate the expected URL for the 1.0.0-ballot release as [canonical]/2025Jan (assuming that you're targeting a January ballot)

@awatson1978
Copy link
Contributor Author

Mmmm... because we've had 4 internal restructurings of the content so far, and 6 minor revisions to page content within the most recent restructuring. I'll update the version and url accordingly....

@lmckenzi
Copy link
Collaborator

From a labeling perspective, you've got CI-build until such time as you're ready to go to ballot, at which point the label is driven by the version of what the target post-ballot publication will be

@awatson1978
Copy link
Contributor Author

awatson1978 commented Oct 2, 2024

Mmmm.... what exactly is the canonical URL? I know where the build URL is....
https://build.fhir.org/ig/HL7/personal-health-record-format-ig/

I see the "Official URL" is:
https://open-health-manager.github.io/standard-patient-health-record-ig/ImplementationGuide/StandardPatientHealthRecordIG

Is that what you mean?

@lmckenzi
Copy link
Collaborator

lmckenzi commented Oct 2, 2024

The canonical URL will be:
http://hl7.org/fhir/[realm]/[code]
where the realm and code are whatever was approved in your IG proposal.

As an example, the canonical for US core is: https://hl7.org/fhir/us/core

The most recent ballot URL was https://hl7.org/fhir/us/core/2024Jan

@awatson1978
Copy link
Contributor Author

Okay... I'm thinking the URLs may be sorted out now.

@awatson1978
Copy link
Contributor Author

@lmckenzi

@lmckenzi
Copy link
Collaborator

lmckenzi commented Oct 7, 2024

Did you see the results of the build?

[schemavalidate] /home/runner/work/JIRA-Spec-Artifacts/JIRA-Spec-Artifacts/xml/FHIR-sphr.xml:2:356: cvc-enumeration-valid: Value 'patientempowerment' is not facet-valid with respect to enumeration '[gas, arb, as, att, brr, cbcc, cdamg, cgit, cimi, cds, cic, cg, cgp, cqi, dev, ec, ehr, director, fgb, fhir-i, fmg, fm, hcd, hsi, hss, hta, ic, project, ii, its, inm, lhs, mh, mnm, oo, pa, pc, pe, pie, pharm, pic, ps, pher, pubs, security, soa, sd, sgb, templates, tsc, tsmg, us-realm, vocab, v2mg, eu, au-v2, au-fhir]'. It must be a value from the enumeration.
[schemavalidate] /home/runner/work/JIRA-Spec-Artifacts/JIRA-Spec-Artifacts/xml/FHIR-sphr.xml:2:356: cvc-attribute.3: The value 'patientempowerment' of attribute 'defaultWorkgroup' on element 'specification' is not valid with respect to its type, 'WorkGroup'.
[schemavalidate] /home/runner/work/JIRA-Spec-Artifacts/JIRA-Spec-Artifacts/xml/FHIR-sphr.xml:38:104: cvc-identity-constraint.4.1: Duplicate unique value [StructureDefinition/pcd-sleep-observation] declared for identity constraint "artifact-id-unique" of element "specification".

The work group code is "pe". You'll need to fix the duplicate id value too.

@lmckenzi lmckenzi merged commit 3391cee into HL7:master Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants