Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FHIR-us-qm.xml #1098

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Updated FHIR-us-qm.xml #1098

merged 4 commits into from
Oct 21, 2024

Conversation

abdullah-git1
Copy link
Contributor

No description provided.

@abdullah-git1
Copy link
Contributor Author

How can I determine the issue if the check indicates that it’s not a valid XML document?

I ran it through an XML validator, and it reports that there are no issues.

@lmckenzi
Copy link
Collaborator

It's not valid against the schema. If you look at the details of the run, you'll see this:
[schemavalidate] /home/runner/work/JIRA-Spec-Artifacts/JIRA-Spec-Artifacts/xml/FHIR-us-qm.xml:161:97: cvc-identity-constraint.4.1: Duplicate unique value [Intended Venue] declared for identity constraint "artifact-name-unique" of element "specification".
[schemavalidate] /home/runner/work/JIRA-Spec-Artifacts/JIRA-Spec-Artifacts/xml/FHIR-us-qm.xml:235:109: cvc-identity-constraint.4.1: Duplicate unique value [eCQM Update 2024] declared for identity constraint "artifact-name-unique" of element "specification".
[schemavalidate] /home/runner/work/JIRA-Spec-Artifacts/JIRA-Spec-Artifacts/xml/FHIR-us-qm.xml:236:97: cvc-identity-constraint.4.1: Duplicate unique value [eCQM Update 2024] declared for identity constraint "artifact-name-unique" of element "specification".

@abdullah-git1
Copy link
Contributor Author

abdullah-git1 commented Oct 18, 2024

@lmckenzi Based on those details, for the first bullet point

Is it safe to assume that reason its not passing the check because the codesystem and valueset have the same name and should not both be called "intended value"?

<artifact id="ValueSet/intended-venue" key="ValueSet-intended-venue" name="Intended Venue"/>
<artifact id="CodeSystem/intended-venue" key="CodeSystem-intended-venue" name="Intended Venue"/>

@lmckenzi
Copy link
Collaborator

Right. Titles have to be unique across all artifacts because they'll all show up as entries in the ToC and multiple titles with the same name will confuse the reader.

@lmckenzi lmckenzi merged commit 6ceb3dc into HL7:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants