Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync to master #29

Merged
merged 4 commits into from
Jul 20, 2019
Merged

Sync to master #29

merged 4 commits into from
Jul 20, 2019

Conversation

Mec-iS
Copy link
Contributor

@Mec-iS Mec-iS commented Jul 17, 2019

No description provided.

de-sh and others added 4 commits June 16, 2019 03:20
@de-sh
Add Travis CI to repo, tests for PEP8
2bc7cb1
@de-sh
Make source files PEP8 conformant
d2f84c2
@xadahiya
Merge pull request #26 from de-sh/develop
099b3d3 
Setup Travis and add necessary PEP8 conformance tests
@vddesai1871 @Mec-iS
Update sample doc and adapt tests. (#28)
fbe05b9 
* Update sample doc and adapt tests.
* Replace readonly and writeonly with readable and writeable.
* Add 'returnsHeader', 'expectsHeader' and 'manages'.
xadahiya
xadahiya approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

gustavodemorais
gustavodemorais reviewed Jul 19, 2019
View reviewed changes
Copy link

@gustavodemorais gustavodemorais left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vddesai1871 is the hydra_doc_sample.py here working with hydrus? We have the drone API under this name in hydrus and the Agent, here we have the Pet Store one, which I wasn't able to make it work previously.

Wanted to have the Drone API in this repo so we maintain it aligned with the spec as the main doc since we're using it a lot in the Agent and hydrus.

@vddesai1871
Copy link
Contributor

Hey @vddesai1871 is the hydra_doc_sample.py here working with hydrus?

I hadn't run it in a while but on getting your comment I tried it and it is working fine for me except for one extra forward slash/ it had in entry point URIs. I have corrected it. If you are facing any other error, I can look into that too.

Wanted to have the Drone API in this repo so we maintain it aligned with the spec as the main doc since we're using it a lot in the Agent and hydrus.

Yeah, it makes sense. It would be better to use drone vocab at all places from hydra-flock-vocab repos as suggested here HTTP-APIs/hydra-flock-vocab#1 but first it would require us to update vocab at hydra-flock-vocab, so I have opened a PR there.
I am using urllib to get the raw jsonld file from my hydra-flock-vocab fork and use it, not sure whether that's the right way to do it...

@vddesai1871 vddesai1871 mentioned this pull request Jul 20, 2019
Merged
@xadahiya
Copy link
Member

Merging #29

@xadahiya xadahiya merged commit b788d35 into master Jul 20, 2019
@gustavodemorais
Copy link

Yeah, I agree it's better to have it in hydra-flock-vocab. Thanks for the correction in the Pet example, I'll continue the discussion at HTTP-APIs/hydra-flock-vocab#1.

This was referenced Jul 20, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavodemorais gustavodemorais gustavodemorais left review comments

@xadahiya xadahiya xadahiya approved these changes

@vddesai1871 vddesai1871 vddesai1871 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mec-iS @vddesai1871 @xadahiya @gustavodemorais @de-sh