Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce 2024 queries #3786

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Ecommerce 2024 queries #3786

wants to merge 34 commits into from

Conversation

jcmpagel
Copy link
Member

@jcmpagel jcmpagel commented Oct 2, 2024

Makes progress on #3609

Hi,
we want to make the Ecommerce chapter happening. I've mostly updated the 2021 queries. In some cases, I adjusted them for 2024, like changing FID to INP for the Core Web Vitals. However, they are 90% the same as before.

slightly adjusted ranks from 2021
updated for new schema
updated for new schema and also added rank for further analysis
Make it more like the CMS one to be 100% sure
@tunetheweb tunetheweb changed the title Ecommerce Chapter quries Ecommerce 2021 queries Oct 11, 2024
@tunetheweb tunetheweb added the analysis Querying the dataset label Oct 11, 2024
@tunetheweb tunetheweb changed the title Ecommerce 2021 queries Ecommerce 2024 queries Oct 13, 2024
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM assuming CI passes. Is this good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Querying the dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants