Detect WordPress theme slugs #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
reviewed
Jan 27, 2025
There was a problem hiding this comment.
@swissspidy Thanks for the PR! Looks good overall, though I think tracking this slightly differently would be more efficient for queries.
felixarntz
reviewed
Jan 27, 2025
dist/cms.js
Outdated
Comment on lines
16
to
17
| theme: '', | ||
| child_theme: '', |
There was a problem hiding this comment.
This works, though related to #157 (comment) it might still be good to differentiate between "unknown" and "none". I'd say if wp-theme-... is present and wp-child-theme-... is not present, we should set child_theme to '' (none).
But if neither of the two are present, we for sure don't know (because every site must have at least a theme). So then using another value for both (e.g. null) to indicate "unknown" would be good.
There was a problem hiding this comment.
So null if both are absent? Works for me.
There was a problem hiding this comment.
Maybe also theme: null if for some reason a wp-child-theme-... class is present, but wp-theme-... isn't. That would be invalid and is probably an edge-case, so might also fine to ignore it.
https://almanac.httparchive.org/en/2022/Changed custom metrics values: {
"_cms": {
"wordpress": {
"theme": {
"theme": null,
"child_theme": null
},
"block_theme": false,
"has_embed_block": false,
"embed_block_count": {
"total": 0,
"total_by_type": []
},
"scripts": [],
"content_type": {
"template": "unknown",
"post_type": "",
"taxonomy": ""
},
"uses_interactivity_api": false,
"interactivity_api_usage": {
"total_regions": 0,
"total_regions_by_namespace": []
}
}
}
}https://ma.ttChanged custom metrics values: {
"_cms": {
"wordpress": {
"theme": {
"theme": "twentythirteen",
"child_theme": "matt"
},
"block_theme": false,
"has_embed_block": true,
"embed_block_count": {
"total": 7,
"total_by_type": {
"soundcloud": 1,
"spotify": 1,
"youtube": 5
}
},
"scripts": [
{
"handle": "the-neverending-homepage",
"src": "https://ma.tt/blog-content/plugins/jetpack/_inc/build/infinite-scroll/infinity.min.js?ver=14.2.1-is5.0.1",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "jp-lite-youtube-embed-script",
"src": "https://ma.tt/blog-content/mu-plugins/jp-lite-youtube-embed/lite-yt-embed.min.js?ver=0.3.2-5",
"in_footer": true,
"async": false,
"defer": true,
"intended_strategy": "defer",
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "wp-polyfill",
"src": "https://ma.tt/blog/wp-includes/js/dist/vendor/wp-polyfill.min.js?ver=3.15.0",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "wp-hooks",
"src": "https://ma.tt/blog-content/plugins/gutenberg/build/hooks/index.min.js?ver=84e753e2b66eb7028d38",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "wp-i18n",
"src": "https://ma.tt/blog-content/plugins/gutenberg/build/i18n/index.min.js?ver=bd5a2533e717a1043151",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": 68,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "wp-jp-i18n-loader",
"src": "https://ma.tt/blog-content/plugins/jetpack-boost/jetpack_vendor/automattic/jetpack-assets/build/i18n-loader.js?minify=true&ver=becd7d9884bc1b331e45",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": 4097,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "wp-url",
"src": "https://ma.tt/blog-content/plugins/gutenberg/build/url/index.min.js?ver=499ac283dc628dfb623e",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "jetpack-instant-search",
"src": "https://ma.tt/blog-content/plugins/jetpack/jetpack_vendor/automattic/jetpack-search/build/instant-search/jp-search.js?minify=false&ver=da5ecd9f722e7fcb409e",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": null,
"before_script_size": 1489,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "jp-tracks",
"src": "https://stats.wp.com/w.js?ver=202505",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "wp-parsely-loader",
"src": "https://ma.tt/blog-content/plugins/wp-parsely/build/loader.js?ver=b681bb9905652ac12735",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "matt-script",
"src": "https://ma.tt/blog-content/themes/ma.tt/js/matt.js?ver=1719254596",
"in_footer": true,
"async": false,
"defer": true,
"intended_strategy": "defer",
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "jetpack-carousel",
"src": "https://ma.tt/blog-content/plugins/jetpack/_inc/build/carousel/jetpack-carousel.min.js?ver=14.2.1",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": null,
"before_script_size": null,
"extra_script_size": 1524,
"translations_script_size": null
},
{
"handle": "gravatar-enhanced-hovercards",
"src": "https://ma.tt/blog-content/plugins/gravatar-enhanced/build/hovercards.js?ver=379f2afa46f37169f7a3",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": null,
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "matt-base-theme-functions",
"src": "https://ma.tt/blog-content/themes/ma.tt/js/base-functions.js?ver=6.8-alpha-59711",
"in_footer": true,
"async": false,
"defer": true,
"intended_strategy": "defer",
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "tiled-gallery",
"src": "https://ma.tt/blog-content/plugins/jetpack/_inc/build/tiled-gallery/tiled-gallery/tiled-gallery.min.js?ver=14.2.1",
"in_footer": true,
"async": false,
"defer": true,
"intended_strategy": "defer",
"after_script_size": null,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
},
{
"handle": "jetpack-stats",
"src": "https://stats.wp.com/e-202505.js",
"in_footer": true,
"async": false,
"defer": false,
"intended_strategy": "defer",
"after_script_size": 219,
"before_script_size": null,
"extra_script_size": null,
"translations_script_size": null
}
],
"content_type": {
"template": "home-blog",
"post_type": "post",
"taxonomy": ""
},
"uses_interactivity_api": false,
"interactivity_api_usage": {
"total_regions": 0,
"total_regions_by_namespace": []
}
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new change in the upcoming WordPress 6.8 release that exposes the slugs of the currently active theme(s) via a class on the
<body>.This makes it easy to track individual theme adoption.
Test websites: