forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial enablement for text-embedding #758
Open
libinta
wants to merge
24
commits into
habana_main
Choose a base branch
from
dev/enable_embedding_ace
base: habana_main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+488
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…such as bert,roberta, bart.
….inf caused nan for softmax calculation.
c0da1e0
to
d65340a
Compare
This was referenced Feb 5, 2025
30f43b5
to
1185c2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial PR for text-embedding with --dtype bfloat16. The following models are tested with 1x and 2x mpi/ray
model
BAAI/bge-base-en-v1.5
BAAI/bge-multilingual-gemma2
intfloat/e5-mistral-7b-instruct
ssmits/Qwen2-7B-Instruct-embed-base
Alibaba-NLP/gte-Qwen2-7B-instruct
There is no Lora support yet.
has dependency with HabanaAI/vllm-hpu-extension#87
offline test use script from https://docs.vllm.ai/en/latest/getting_started/examples/embedding.html with adding dtype="bfloat16" in LLM call
sample cmds such as
python testscript.py
VLLM_SKIP_WARMUP=true python testscript.py
online test use client script from https://docs.vllm.ai/en/latest/getting_started/examples/openai_embedding_client.html
server sample cmds such as
vllm serve Alibaba-NLP/gte-Qwen2-7B-instruct --task embed --dtype bfloat16
VLLM_SKIP_WARMUP=true VLLM_PROMPT_USE_FUSEDSDPA=true vllm serve Alibaba-NLP/gte-Qwen2-7B-instruct --task embed --dtype bfloat16