Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile Page 2024 #523

Merged
merged 35 commits into from
Feb 6, 2024
Merged

Profile Page 2024 #523

merged 35 commits into from
Feb 6, 2024

Conversation

AdityaK2905
Copy link
Contributor

@AdityaK2905 AdityaK2905 commented Dec 3, 2023 •
edited by leahlud
Loading

  • Added dependency for loading avatar image from url
  • Updated UI and added api calls and fragment logic for new features (i.e. pro tag, ranking, etc)

@AdityaK2905 AdityaK2905 changed the title Added dependency for loading avatar image from url Profile Page 2024 Dec 3, 2023
@leahlud leahlud linked an issue Dec 3, 2023 that may be closed by this pull request
Profile Page 2024 #508
Closed
11 tasks
AdityaK2905 and others added 17 commits December 23, 2023 19:41
@AdityaK2905
Merge branch 'development' of https://github.com/HackIllinois/android …
a2bcd05 
…into aditya/profile-2024
@AdityaK2905
Just some basic xml files right now
1a482d7
@AdityaK2905
Started adding profile structure for staff vs attendee and worked on …
7688dc2 
…profile UI
@leahlud
fixed ktlint issues
b7587c7
@leahlud
Merge branch 'development' into aditya/profile-2024
c7e8f75
@AdityaK2905
More layout and UI work
95b9884
@AdityaK2905
fixed ktlint errors
36428b3
@AdityaK2905
Added drawables; UI nearly done, logic soon
18573be
@AdityaK2905
more profile UI; need help with centering ranking in horizontal linea…
ef8c833 
…r layout
@AdityaK2905
Added UI suggestions like using stroke instead of second card view an…
820fc0f 
…d removing duplicate constraints.
@leahlud
temp UI changes
b953e2f
@AdityaK2905
Created new profile layout file using less layouts and also upscaled …
1893727 
….pngs
@leahlud
Merge remote-tracking branch 'origin/aditya/profile-2024' into aditya…
e688556 
…/profile-2024
@leahlud
Updated fragment_profile_2024.xml with fixed colors and hardcoded pos…
a5571f7 
…itions

This reverts commit b953e2f.
@AdityaK2905
Replaced some images with svgs and added guidelines
1ad6394
@AdityaK2905
worked on ProfileFragment and added image loading utilities for avatar
0c9e1b4
@leahlud
Fixed some constraints, colors, and minor layout changes
8aa86a0
@leahlud
Copy link
Contributor

leahlud commented Jan 10, 2024 •
edited
Loading

  • Can you make those squiggly details SVGs as well since they are a bit blurry? Also I think the left and right designs are swapped, like they're facing the wrong way when compared to the Figma
image
  • You can delete the old fragment_profile.xml file and rename the 2024-redone one to fragment_profile.xml (instead of copying it over)
  • we are going back to encoding what we did originally (qrInfo from the user/qr/ endpoint), pull it every 15 seconds
  • remove staff profile view
  • change "Pro" label to be "Knight"
  • call profile/ranking to obtain and display ranking

@leahlud leahlud self-requested a review February 6, 2024 22:59
@leahlud leahlud merged commit afe19e0 into development Feb 6, 2024
2 checks passed
@leahlud leahlud deleted the aditya/profile-2024 branch February 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahlud leahlud leahlud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile Page 2024
2 participants
@AdityaK2905 @leahlud