Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attendee and Staff Scanner menu update #613

Merged
merged 10 commits into from
Feb 12, 2025
Merged

Attendee and Staff Scanner menu update #613

merged 10 commits into from
Feb 12, 2025

Conversation

nathannwangg
Copy link
Contributor

@nathannwangg nathannwangg commented Jan 31, 2025 •
edited
Loading

Description

  • Added and updated background images for attendee and staff scanner menus
  • Added new colors to HIAppearance.swift for updated scanner buttons that match the new 2025 designs. Replaced old definitions of scannerButton colors with the new colors
  • Edited the definition of QRSelection style in HILabel.swift to change the scanner button text colors to white, replacing last year's brown
  • Updated the colors for all attendee scanner buttons and changed the view title color to white
  • Updated the colors for all staff scanner buttons and changed the view title style to viewTitle instead of viewTitleBrown

Screenshots

image

image

@nathannwangg
Added new background images to attendee and staff scanner menus.
d22cdb1
@nathannwangg
Merge branch 'dev'
f6028db
@nathannwangg
Added new colors to HIAppearance for updated scanner buttons that mat…
c76b2de 
…ch the new 2025 designs. Replaced old definitions of scannerButton colors with the new colors.
@nathannwangg
Edited the definition of the QRSelection style to change the scanner …
68aa6c7 
…button text color to white and replace last year's brown.
@nathannwangg
Udpated the colors for each attendee scanner button and changed the v…
c16f17a 
…iew title color to white replacing last year's brown.
@nathannwangg
Updated colors for staff scanner buttons and changed the view title s…
d4b23ba 
…tyle to viewTitle instead of viewTitleBrown to match the 2025 design of white titles instead of the old brown.
@anushkasankaran
Copy link
Contributor

Great job! Only thing is I think the Points Shop button is available for staff, not attendees.

@nathannwangg
Migrated the Points Shop scanner button from the attendee scanner sel…
805280c 
…ection menu to the staff scanner selection menu.
@nathannwangg
Copy link
Contributor Author

Just moved the points shop scanner button to the staff scanner selection menu and removed it from the attendee scanner selection menu.

Screenshots:

image

image

anushkasankaran
anushkasankaran approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@anushkasankaran anushkasankaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anushkasankaran anushkasankaran merged commit 6438edf into dev Feb 12, 2025
2 checks passed
@anushkasankaran anushkasankaran deleted the scanner-menu-update branch February 12, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anushkasankaran anushkasankaran anushkasankaran approved these changes

@lasyaneti lasyaneti Awaiting requested review from lasyaneti lasyaneti is a code owner

@s0phialiu s0phialiu Awaiting requested review from s0phialiu s0phialiu is a code owner

@AydanPirani AydanPirani Awaiting requested review from AydanPirani AydanPirani is a code owner

@Timothy-Gonzalez Timothy-Gonzalez Awaiting requested review from Timothy-Gonzalez Timothy-Gonzalez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathannwangg @anushkasankaran