Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Location and Map Caching Fix #634

Merged
merged 4 commits into from
Feb 23, 2025
Merged

Event Location and Map Caching Fix #634

merged 4 commits into from
Feb 23, 2025

Conversation

nathannwangg
Copy link
Contributor

@nathannwangg nathannwangg commented Feb 23, 2025 •
edited
Loading

Description

  • Added self.mapview.image = nil before the if let mapUrl = URL(string: imageUrlString) check in HIEventDetailViewController.swift
  • Changed coreDataEvent.addToLocations(coreDataLocation) to replace, not append, by adding coreDataEvent.removeFromLocations(coreDataLocation) before it in HIEventDataSource.swift

@nathannwangg
set self.mapView.image to nil before the if let mapUrl = URL(string: …
d7cb184 
…imageUrlString) check in HIEventDetailViewController.swift. Added coreDataEvent.removeFromLocations before coreDataEvent.addToLocations in HIEventDataSource.swift
@anushkasankaran anushkasankaran merged commit 2c9e96e into dev Feb 23, 2025
2 checks passed
@anushkasankaran anushkasankaran deleted the caching-fix branch February 23, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anushkasankaran anushkasankaran anushkasankaran approved these changes

@lasyaneti lasyaneti Awaiting requested review from lasyaneti lasyaneti is a code owner

@s0phialiu s0phialiu Awaiting requested review from s0phialiu s0phialiu is a code owner

@AydanPirani AydanPirani Awaiting requested review from AydanPirani AydanPirani is a code owner

@Timothy-Gonzalez Timothy-Gonzalez Awaiting requested review from Timothy-Gonzalez Timothy-Gonzalez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathannwangg @anushkasankaran