Close Button for Modal #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
miguelaenlle
commented
Feb 2, 2025
miguelaenlle
commented
- Added cancel button to the modal view:
✅ Deploy Preview for hackillinois ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
J164
requested changes
Feb 5, 2025
There was a problem hiding this comment.
This style doesn't seem to be applying. Maybe the svg should be wrapped in a button (or the style could apply to the svg)?
There was a problem hiding this comment.
Hi @J164 . I wrapped the svg component in a button, so that the hover style would apply to the close button.
For reference, here's what the button looks like now:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.