Reworked Config #33
Merged
Reworked Config #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helithumper
reviewed
Mar 18, 2024
Helithumper
reviewed
Mar 18, 2024
Helithumper
reviewed
Mar 18, 2024
Helithumper
reviewed
Mar 18, 2024
Helithumper
reviewed
Mar 18, 2024
|
I can help either this week or weekend with anything in here if you need it. |
Switched config to a type validated pydantic setting class Introduces breaking changes to config file add support for bitwarden secrets manager
Fixed Forms to return proper execptions
jontyms
force-pushed
the
reworked-config
branch
from
8593520 to
1c578e6
Compare
Helithumper
reviewed
Mar 18, 2024
util/options.py
Outdated
|
|
||
| return options.get(arg, None) | ||
| # Reads config from ../config/options.yml | ||
| here = os.path.abspath(os.path.dirname(__file__)) |
There was a problem hiding this comment.
Instead of doing this raw in the python file, it's probably best to make Settings() into a different class and add this to the constructor with "options.yml" as the default value.
There was a problem hiding this comment.
I am going to be honest I have no idea how that function works, chatgpt wrote it
Helithumper
reviewed
Mar 18, 2024
Helithumper
reviewed
Mar 18, 2024
Helithumper
reviewed
Mar 18, 2024
Helithumper
reviewed
Mar 18, 2024
fixed command injection in settings module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched config to a type validated pydantic setting class Introduces breaking changes to config file
add support for bitwarden secrets manager
fixed #4
supersedes #32
TODO