Merge pull request github#36023 from github/repo-sync

Repo sync
Hadiismanto11 · Jan 22, 2025 · 4c432fb · 4c432fb
2 parents c80a47f + 6c789b8
commit 4c432fb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/frame/middleware/index.ts b/src/frame/middleware/index.ts
@@ -113,7 +113,7 @@ export default function (app: Express) {
   }
 
   // *** Observability ***
-  if (process.env.MODA_PROD_SERVICE_ENV) {
+  if (process.env.MODA_PROD_SERVICE_ENV === 'true') {
     app.use(datadog)
   }
 

diff --git a/src/observability/lib/statsd.js b/src/observability/lib/statsd.js
@@ -9,7 +9,7 @@ const {
   DD_AGENT_HOST,
 } = process.env
 
-const mock = NODE_ENV === 'test' || !MODA_PROD_SERVICE_ENV
+const mock = NODE_ENV === 'test' || MODA_PROD_SERVICE_ENV !== 'true'
 
 // MODA_APP_NAME gets set when the deploy target is Moda
 const modaApp = MODA_APP_NAME ? `moda_app_name:${MODA_APP_NAME}` : false

diff --git a/src/observability/middleware/trigger-error.ts b/src/observability/middleware/trigger-error.ts
@@ -15,7 +15,8 @@ export default async function triggerError(
   // pattern used on async middleware! This is an intentional omission!
 
   // prevent this from being used in production
-  if (process.env.NODE_ENV === 'production' && process.env.MODA_PROD_SERVICE_ENV) return next()
+  if (process.env.NODE_ENV === 'production' && process.env.MODA_PROD_SERVICE_ENV === 'true')
+    return next()
 
   throw new Error('Intentional error')
 }