-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inverted suit #2968
base: main
Are you sure you want to change the base?
Add inverted suit #2968
Conversation
i wouldn't worry about interactions with detrimental characters, they will probably be deleted in the long term, as they are too much of a maintenance burden |
Original post edited to reflect that detrimental characters won't be considered, and that a merge/rebase needs to be done to make it mergeable again. |
I would be kinda sad for it to be completely delated. Maybe make it as an option only for no var/make it a variant |
Merged to match main; fixed to pass CI/lint; made bottom-deck-plays also allow discards for inverted games. https://github.com/IceSelkie/hanabi-live/actions/runs/11310399814 The main functionality is working, so this can probably be merged now. A few improvements could be made in the future, and I don't know if I'll have much time to investigate these:
|
i think it should be some other color instead of black? |
Oh right, I meant to change that. I'll can go add a new Color of "Inverted". (Though it does works fine now and look how I want; I'm not sure if the word "black" or "K" show up anywhere at the moment, and you can't get any black in the same game as inverted, since I only added "Inverted (5 suits)" and "Inverted (6 suits)" as of now) |
by the way, why not inverted 3 suits and 4 suits? |
Inverted Suit as proposed in #2937 (and also one of the many suits proposed in #1720 (Ash)).
The inverted suit should play when you try discard, and discard when you try to play.
This seems to work fairly well for the client side view, however a few issues have been found when I was testing it with some friends.
Todo (beyond fixing above)
Will not do (see Zamiell's comment below):
Where I am hooking in to make the play/discard swap might not be the best place. If someone who knows the code better knows a better place to put this in, do let me know.