Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony 7 #12

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Allow symfony 7 #12

merged 1 commit into from
Apr 19, 2024

Conversation

thomasbeaujean
Copy link
Contributor

Hi, this PR to allow SF7 in composer.json.

I also updated the tests, I had to remove the usage of AnnotationLoader that is not anymore in SF7

@epitre
Copy link

epitre commented Apr 17, 2024

@Nyholm Is it still useful to support symfony 3.4, 4.4, etc... ?

@Nyholm
Copy link
Member

Nyholm commented Apr 18, 2024

No, I dont think so. Feel free to bump.

@epitre
Copy link

epitre commented Apr 18, 2024

@thomasbeaujean good for you ?

@thomasbeaujean thomasbeaujean force-pushed the sf7 branch 4 times, most recently from b215fee to 3146112 Compare April 18, 2024 15:07
Allow symfony 7
@thomasbeaujean
Copy link
Contributor Author

Done, I had to adapt the CI matrix to match the SF php compatibility.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit caff067 into Happyr:master Apr 19, 2024
10 checks passed
@thomasbeaujean thomasbeaujean deleted the sf7 branch April 19, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants