Added a new web page for dictionary #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| console.log(request.savedArticles.URL) | ||
| console.log(allSavedArticles[i].URL) | ||
| if(request.savedArticles.URL === allSavedArticles[i].URL && i == len-1){ | ||
| j=10; |
There was a problem hiding this comment.
To have a check whether the loop is terminated at i = allSavedArticles.length, it is an extra condition. j=10, the value is specified only for a check, any value can be specified.
There was a problem hiding this comment.
try using boolean expression for the same. Boolean is made for the purpose.
extension/templates/options.html
Outdated
| <br> | ||
| <hr> | ||
| <div class="row"> | ||
| <!-- <br> |
There was a problem hiding this comment.
pls remove these multiple comments cluster, and add a single comment
There was a problem hiding this comment.
I have made the changes accordingly and made the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11
Added a new web page for dictionary view.
#20
fixed the bug in the article view section of saving the same articles twice.
Now an article with the same URL will not be saved again if it was saved earlier.