Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Windows compatibility #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philippefs35
Copy link

@philippefs35 philippefs35 commented Apr 29, 2024

Tested on Windows 11 with Visual Studio 2022 C++ compiler.

Introduced a few changes that should be compatible across OSes, namely:

  • Explicitly cast file paths to strings when they are used as such
  • Used the miniz library to unzip archives rather than OS-specific tools ("unzip" command)

file paths to strings and by using the miniz
library to unzip files rather than OS-specific
tools.
@philippefs35 philippefs35 changed the title Enabling windows compatibility Enabling Windows compatibility Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant