Implement updates from internal review

[spengrah]

• changes the name to HatsAccount
• cleans up comments, natspec, and dependencies
• more sensible rejection threshold
• more efficient valid vote counting

[gershido]

Regarding the following function:

  function isExecutableNow(bytes32 _proposalId, address[] calldata _voters) external view returns (bool) {
    _checkExecutableNow(_proposalId, _voters);
    return true;
  }

_checkExecutableNow reverts if not executable, returns true if yes. A slightly different design here can be that _checkExecutableNow won't have a return value at all. Then the view function isExecutableNow can have the actual logic and return true/false, and the internal_checkExecutableNow will use it and revert or not. Same also with isRejectableNow

[gershido]

Wonder if we want to add the tx parameters to the TxExecuted event:

  function execute(address _to, uint256 _value, bytes calldata _data, uint8 _operation)
    external
    payable
    returns (bytes memory result)
  {
    if (!_isValidSigner(msg.sender)) revert InvalidSigner();


    // increment the state var
    _beforeExecute();


    // execute the call, routing delegatecalls through the sandbox, and bubble up the result
    result = LibHatsAccount._execute(_to, _value, _data, _operation);


    // log the executor
    emit TxExecuted(msg.sender);
  }

[spengrah]

Wonder if we want to add the tx parameters to the TxExecuted event:

@gershido my thinking in leaving them out was that we could get them from the tx args. But happy to include them in the event if that would improve things on the subgraph side

[spengrah]

added improvements based on discussion with @gershido:

• even more efficient valid vote counting
• simplify/consolidate logic for _checkExecutableNow and isExecutableNow and Rejectable equivalents

may add tx params to the HatsAccount1ofN.TxExecuted event pending @gershido's subgraph research

[gershido]

Lgtm!

Regarding the HatsAccount1ofN.TxExecuted event, it won't be a problem to index the call info with the current implementation.