Merge pull request #71 from Hats-Protocol/feat/tophat-details

Add `details` to tophat
Hats-Protocol · Dec 7, 2022 · 966cc08 · 966cc08
2 parents 17347b1 + 99b9ada
commit 966cc08
Show file tree

Hide file tree

Showing 5 changed files with 118 additions and 68 deletions.
diff --git a/script/Hats.s.sol b/script/Hats.s.sol
@@ -43,8 +43,9 @@ contract DeployHatsAndMintTopHat is Script {
         Hats hats = new Hats(name, imageURI);
 
         string memory image = "";
+        string memory details = "";
 
-        uint256 tophat = hats.mintTopHat(deployer, image);
+        uint256 tophat = hats.mintTopHat(deployer, details, image);
 
         console2.log("hats: ", address(hats));
         console2.log("tophat: ", tophat);

diff --git a/src/Hats.sol b/src/Hats.sol
@@ -89,17 +89,18 @@ contract Hats is IHats, ERC1155, HatsIdUtilities {
     /// @param _imageURI The image uri for this top hat and the fallback for its
     ///                  downstream hats [optional]
     /// @return topHatId The id of the newly created topHat
-    function mintTopHat(address _target, string memory _imageURI)
-        public
-        returns (uint256 topHatId)
-    {
+    function mintTopHat(
+        address _target,
+        string memory _details,
+        string memory _imageURI
+    ) public returns (uint256 topHatId) {
         // create hat
 
         topHatId = uint256(++lastTopHatId) << 224;
 
         _createHat(
             topHatId,
-            "", // details
+            _details, // details
             1, // maxSupply = 1
             address(0), // there is no eligibility
             address(0), // it has no toggle

diff --git a/src/Interfaces/IHats.sol b/src/Interfaces/IHats.sol
@@ -20,9 +20,11 @@ import "./HatsErrors.sol";
 import "./HatsEvents.sol";
 
 interface IHats is IHatsIdUtilities, HatsErrors, HatsEvents {
-    function mintTopHat(address _target, string memory _imageURI)
-        external
-        returns (uint256 topHatId);
+    function mintTopHat(
+        address _target,
+        string memory _details,
+        string memory _imageURI
+    ) external returns (uint256 topHatId);
 
     // function createTopHatAndHat(
     //     string memory _details,