Do not add host architecture if an arm architecture is set #1079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
HXCPP_ARMV7
is set for example, hxcpp ignores it and adds the host architecture as if no architecture were set. This causes problems, for example, because it might result in bothHXCPP_ARMV7
andHXCPP_ARM64
being set at once, which breaks some toolchains:hxcpp/toolchain/iphoneos-toolchain.xml
Lines 43 to 47 in 18f87b9
(This leads to
-arch armv7 arm64
being passed to the compiler, which causesError: clang: error: no such file or directory: ‘arm64’
).This patch prevents the host architecture being added if any of the following are defined:
HXCPP_ARMV6
,HXCPP_ARMV7
,HXCPP_ARMV7S
.