Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add host architecture if an arm architecture is set #1079

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

tobil4sk
Copy link
Member

Currently if HXCPP_ARMV7 is set for example, hxcpp ignores it and adds the host architecture as if no architecture were set. This causes problems, for example, because it might result in both HXCPP_ARMV7 and HXCPP_ARM64 being set at once, which breaks some toolchains:

<flag value="-arch"/>
<flag value="armv6" if="HXCPP_ARMV6" />
<flag value="armv7" if="HXCPP_ARMV7" />
<flag value="armv7s" if="HXCPP_ARMV7S" />
<flag value="arm64" if="HXCPP_ARM64" />

(This leads to -arch armv7 arm64 being passed to the compiler, which causes Error: clang: error: no such file or directory: ‘arm64’).

This patch prevents the host architecture being added if any of the following are defined: HXCPP_ARMV6, HXCPP_ARMV7, HXCPP_ARMV7S.

@tobil4sk
Copy link
Member Author

@Simn green here now also, thanks.

@Simn Simn merged commit 0ab4cf0 into HaxeFoundation:master Jun 25, 2024
100 checks passed
@tobil4sk tobil4sk deleted the fix/armv7-build branch June 25, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants