Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip warning messages when running vernacular queries #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sakekasi
Copy link
Contributor

No description provided.

@HazardousPeach
Copy link
Owner

Hmm, what's the downside to just doing this filtering on the client side? What if there's a user that wants the warning messages for something?

I could potentially see splitting it into two functions, one of which handles the "common" case where you don't want to see the warnings, and the other gives you everything.

@sakekasi
Copy link
Contributor Author

Hmm, what's the downside to just doing this filtering on the client side? What if there's a user that wants the warning messages for something?

I could potentially see splitting it into two functions, one of which handles the "common" case where you don't want to see the warnings, and the other gives you everything.

I guess it's OK to filter on the client side. In that case, we would still need to add warnings as acceptable feedback messages in self._isFeedbackMessage(). The main problem I've been dealing with is that if serapi ever sends a warning, this causes a series of cascading errors.

@sakekasi
Copy link
Contributor Author

If you're fine with it also returning warnings, that's fine with me

@sakekasi
Copy link
Contributor Author

@HazardousPeach , updated this PR to include warnings in the feedback messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants