Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed EOut/Eover window events for JS target #1084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepnight
Copy link
Contributor

Issue: current onMouseLeave() method fires an EReleaseOutside event to targets, which is inconsistent:

  1. the button value is always zero, no matter if the user "left" the canvas with a mouse button pressed or not.
  2. the expected event should be EOut here.

Fix:

  1. replaced the previously not working EReleaseOutside with EOut
  2. added an onMouseEnter callback as well to support EOver

@ncannasse
Copy link
Member

What about EReleaseOutside if a EPush was triggered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants