Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cylindrical mode solver (signs + H-field calculations) #103

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

lucasgrjn
Copy link
Contributor

The present commit solves the issues associated with the Julia cylindrical mode solver

  • Correct the $2\pi$-factor in the defenition of $\omega$ in the mode-solver.
  • The signs of the H-fields calculated from the E-fields are corrected for both the cylindrical and non-cylindrical mode solver.
  • Julia bend solver examples were updated by considering a 3-order PML (in order to obtain a 2-order PML after derivation of the function as presented in Jedidi, Rym, and Roger Pierre. "High-order finite-element methods for the computation of bending loss in optical waveguides." Journal of Lightwave Technology 25.9 (2007): 2618-2630.)

@HelgeGehring
Copy link
Owner

looks good, thanks!
i think it would be good to remove in the examples the pml_y (i.e. set it to 0) to be consistent with the paper, right?

@HelgeGehring
Copy link
Owner

Thanks!

@lucasgrjn
Copy link
Contributor Author

Julia Formatter should work now!

@HelgeGehring
Copy link
Owner

Yay, thanks!

@HelgeGehring HelgeGehring merged commit 19fde20 into HelgeGehring:main Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants