Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images to RF waveguide tutorial #166

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

duarte-jfs
Copy link
Contributor

Added images to the gitignore file

@HelgeGehring
Copy link
Owner

You don't need to add them to the gitignore, once something is added (you can still add ignored files just with git add) it'll keep being tracked :)
About the images, can we just post pictures of papers? Don't know if that's allowed 🤔

@simbilod
Copy link
Contributor

simbilod commented Jun 6, 2024

You don't need to add them to the gitignore, once something is added (you can still add ignored files just with git add) it'll keep being tracked :) About the images, can we just post pictures of papers? Don't know if that's allowed 🤔

Typically there are links in articles to ask to reproduce figures. Depending on the journal and where you want to reuse the material, it may be free or cost something.

@duarte-jfs
Copy link
Contributor Author

duarte-jfs commented Jul 29, 2024

Apologies. I will close this pull request and create new ones, one for each topic.

EDIT: Reverted the commit on the meshing.

@duarte-jfs duarte-jfs closed this Jul 29, 2024
This reverts commit 995a03d.
@duarte-jfs duarte-jfs reopened this Jul 29, 2024
@HelgeGehring
Copy link
Owner

Thanks for the new PR!

How do we go on with this? Should we do our own pictures? Or does the journal have clear rules on reproducing pictures?

@duarte-jfs
Copy link
Contributor Author

I say we just remove the figure and don't take any chances. It's not crucial to have the figure, and later we compare with data extracted from the paper

@HelgeGehring
Copy link
Owner

Looks good! The four remaining pictures you made yourself?

Did you by chance make them using some vector graphic tool (e.g. inkscape) and could upload them as a svg file? That way the pictures would be adjustable just like the rest of the docs (and the files also smaller :) )

@HelgeGehring
Copy link
Owner

Hey, we can also just remove those pictures and refer to the paper :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants