-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add images to RF waveguide tutorial #166
base: main
Are you sure you want to change the base?
Conversation
You don't need to add them to the gitignore, once something is added (you can still add ignored files just with git add) it'll keep being tracked :) |
Typically there are links in articles to ask to reproduce figures. Depending on the journal and where you want to reuse the material, it may be free or cost something. |
Apologies. I will close this pull request and create new ones, one for each topic. EDIT: Reverted the commit on the meshing. |
This reverts commit 995a03d.
Thanks for the new PR! How do we go on with this? Should we do our own pictures? Or does the journal have clear rules on reproducing pictures? |
I say we just remove the figure and don't take any chances. It's not crucial to have the figure, and later we compare with data extracted from the paper |
Looks good! The four remaining pictures you made yourself? Did you by chance make them using some vector graphic tool (e.g. inkscape) and could upload them as a svg file? That way the pictures would be adjustable just like the rest of the docs (and the files also smaller :) ) |
Hey, we can also just remove those pictures and refer to the paper :) |
Added images to the gitignore file