Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips to action icons in request page #2790

Closed
wants to merge 4 commits into from

Conversation

use-tusk[bot]
Copy link
Contributor

@use-tusk use-tusk bot commented Oct 16, 2024

Fixes #2788

This change adds tooltips to action icons in the request page to improve user experience by providing clear indications of each icon's function. The tooltips have been added to the refresh button, the live/start live button, and the view change button. Additionally, title attributes have been added to dropdown menu items for simple tooltips.


Tips:

  • Make sure to test changes before merging.
  • Submit a "Request Changes" review to address nits. If major changes are needed, retry the issue from the Tusk app with additional context.
  • Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
  • Go to the Tusk activity logs or issue to see more details.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helicone ❌ Failed (Inspect) Oct 16, 2024 9:53pm
helicone-bifrost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:53pm
helicone-eu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:53pm

Copy link
Collaborator

@colegottdank colegottdank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed: Error: DropdownMenuTrigger must be used within DropdownMenu

Copy link
Contributor Author

use-tusk bot commented Oct 16, 2024

Addressing your review. View activity logs for details.

@use-tusk use-tusk bot force-pushed the tusk-2788-tooltip-icons-101620241948 branch from 9a0ffb8 to 412e577 Compare October 16, 2024 21:26
Copy link
Contributor Author

use-tusk bot commented Oct 16, 2024

@colegottdank I've addressed your review. Add another review if minor changes are needed. If major changes are needed, retry the issue from the Tusk app with additional context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The view, multi-select, etc. icons don't have any text on hover
1 participant