-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type annotations with using type.List
.
#90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @azriel1rf, nice to see you back!
The PR looks good to me. Ready to merge.
My question is, does this change break our library in Python3.7? If it does, we may have to increase the major version number (i.e. 0.6.0) when we release a new package. Also, maybe it is a good time to start using different versioning in our Python and C++ library. (Since C++ has already been in 0.6.0 with new PLO5 and PLO6 features, and some features deprecated.) But these are the next steps.
To clarify, this change doesn't affect Python 3.7 functionality, as the type annotation issue is specific to versions below 3.9. However, I removed Python 3.7 support since it has reached end-of-life. Regarding versioning, while incrementing for language-specific features may seem frequent, we should consider the impact on users. How about creating a |
Hi @azriel1rf, I think your approach is good. I didn't choose this approach previously because I found it overfitting for this small repo. However, since now we have multiple languages and increasing number of bug fixes and features, it is time for us to change the style of managing the repo now. The only catch is that we need to make sure contributors are checking out the code in development branch. I'll add a note in the Let me merge this PR, and then I'll create a development branch named |
@HenryRLee Thanks! |
@HenryRLee Thank you for creating the |
Fix type annotations in Python for issue #75
This pull request addresses the type annotation errors raised by mypy when running
mypy .
. The necessary changes have been made to resolve these errors.Additonal Notes: