Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add ExperimentalFeatures feature with dummy example #2881

Merged
merged 4 commits into from
Sep 10, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jul 22, 2023

This PR adds a new concept of Experimental Features that we can use when developing new stuff that we add into heroic (new design, new stores, some shiny new feature, whatever).

It shows a list of features in the Advanced settings and users can opt-in to help test new features before they are marked as stable.

It's added with a dummy sample on how to use it and how to add flags to configure:

experimental.mp4

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team July 22, 2023 03:46
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 29, 2023
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but are we keeping the shiny feature? only if you make Heroic shine :P

@arielj
Copy link
Collaborator Author

arielj commented Sep 7, 2023

Looks good, but are we keeping the shiny feature? only if you make Heroic shine :P

hahaah, it could be an easter egg to add some shiny effects xD

@arielj arielj merged commit aaadda2 into main Sep 10, 2023
13 checks passed
@arielj arielj deleted the experimental-features branch September 10, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants