Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix three-dots menu closing when hovering certain items #2929

Merged
merged 1 commit into from
Aug 4, 2023
Merged

[Fix] Fix three-dots menu closing when hovering certain items #2929

merged 1 commit into from
Aug 4, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jul 29, 2023

This PR fixes #2915

The menu was rendered with z-index: 0 by default and the elements like Installed Information Game Scores etc had the same z-index value, because they come after in the DOM they had the focus.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 29, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team July 29, 2023 14:13
flavioislima
flavioislima approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arielj arielj added this to the 2.9.2 milestone Jul 30, 2023
@arielj arielj merged commit f2e437f into main Aug 4, 2023
13 checks passed
@arielj arielj deleted the fix-dots-menu-closing branch August 4, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

Three dot menu issue
2 participants
@arielj @flavioislima