Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Installation of EOS Overlay #2930

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jul 29, 2023

This PR fixes #2916 and fixes #2905

I added some code to prevent running the same command twice in parallel (to prevent the epic logout issue), but I didn't know that then and catch on promises does NOT change the current promise but it actually returns a new object, so I was storing/caching the current promise without handling the catch.

Because the first step installing the overlay is to get the size and then abort the command, it was throwing an exception instead of handling it silently.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 29, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team July 29, 2023 14:45
@arielj arielj added this to the 2.9.2 milestone Jul 29, 2023
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the process still isn't perfect again, originally it also displayed the progress of the install in the sidebar, like regular game downloads do, but after looking at the code, this seems a lot more difficult to implement with the download manager & it working is of course the important part

@arielj
Copy link
Collaborator Author

arielj commented Aug 1, 2023

Seems like the process still isn't perfect again, originally it also displayed the progress of the install in the sidebar, like regular game downloads do, but after looking at the code, this seems a lot more difficult to implement with the download manager & it working is of course the important part

looks like that has been broken for a long time, I tried with Heroic 2.7 and 2.8 it was already not displaying the EOS installation in the sidebar

@arielj arielj merged commit e7a478f into main Aug 4, 2023
13 checks passed
@arielj arielj deleted the fix-installing-eos-overlay branch August 4, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
2 participants