[Fix] Installation of EOS Overlay #2930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2916 and fixes #2905
I added some code to prevent running the same command twice in parallel (to prevent the epic logout issue), but I didn't know that
then
andcatch
on promises does NOT change the current promise but it actually returns a new object, so I was storing/caching the current promise without handling the catch.Because the first step installing the overlay is to get the size and then abort the command, it was throwing an exception instead of handling it silently.
Use the following Checklist if you have changed something on the Backend or Frontend: