Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Alignment of current download component when sidebar is collapsed #2933

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jul 29, 2023

This PR fixes #2838

The alignment of the icon is not perfect so the % was a bit cut-off on the side:

Before:
image

After:
image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 29, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team July 29, 2023 17:57

.statusIcon {
display: none;
margin-inline-end: 10px;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the important change in this file, the rest is just that I moved the file to be a scss file

@@ -166,6 +162,7 @@
}

.currentDownloads {
margin-inline: auto;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just center the element when collapsed instead of having a fixed left margin

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏽

@arielj arielj added this to the 2.9.2 milestone Jul 30, 2023
@arielj arielj merged commit 776c8bb into main Aug 4, 2023
13 checks passed
@arielj arielj deleted the fix-collapsed-sidebar-download branch August 4, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI nit: icon for installing with percentage is not responsive to sidebar's width
2 participants