Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vulkan-helper and gogdl binaries #2961

Merged
merged 1 commit into from
Aug 7, 2023
Merged

update vulkan-helper and gogdl binaries #2961

merged 1 commit into from
Aug 7, 2023

Conversation

imLinguin
Copy link
Member

Closes #2960 - vulkan-helper is now built on ubuntu 20.04
Closes #2953 - gogdl update to commit Heroic-Games-Launcher/heroic-gogdl@89d15f1

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 6, 2023
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC and Nocccer and removed request for a team August 6, 2023 11:03
@arielj arielj added this to the 2.9.2 milestone Aug 6, 2023
arielj
arielj approved these changes Aug 6, 2023
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to test the vulkan-helper, but I did test the gogdl binary in linux and things are working fine (I can get install info and install a game with no timeout issues)

@imLinguin imLinguin merged commit 7bb80ec into main Aug 7, 2023
13 checks passed
@imLinguin imLinguin deleted the update-bin branch August 7, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.9.2
2 participants
@imLinguin @arielj