Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech] Update electron to version 26.2.1 #3053

Closed
wants to merge 1 commit into from
Closed

[Tech] Update electron to version 26.2.1 #3053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@
"@typescript-eslint/parser": "^5.47.1",
"@vitejs/plugin-react-swc": "^3.2.0",
"cross-env": "^7.0.3",
"electron": "castlabs/electron-releases#24.4.1+wvcus",
"electron": "castlabs/electron-releases#26.2.1+wvcus",
"electron-builder": "^23.6.0",
"electron-devtools-installer": "^3.2.0",
"electron-playwright-helpers": "^1.5.5",
Expand Down
2 changes: 1 addition & 1 deletion src/backend/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ ipcMain.on('unlock', () => {
unlinkSync(join(gamesConfigPath, 'lock'))
if (powerId) {
logInfo('Stopping Power Saver Blocker', LogPrefix.Backend)
return powerSaveBlocker.stop(powerId)
powerSaveBlocker.stop(powerId)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change this cause typescript starts complaining about this function with electron 26 (not all code paths returned a value)

}
}
})
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3543,9 +3543,9 @@ electron-updater@^5.0.1:
semver "^7.3.5"
typed-emitter "^2.1.0"

electron@castlabs/electron-releases#24.4.1+wvcus:
version "24.4.1"
resolved "https://codeload.github.com/castlabs/electron-releases/tar.gz/382f71fa5495e1523d6677fa96b3d3c583d79e3a"
electron@castlabs/electron-releases#26.2.1+wvcus:
version "26.2.1"
resolved "https://codeload.github.com/castlabs/electron-releases/tar.gz/e5fad1db625a4414ab2000c2f1456586fc33af42"
dependencies:
"@electron/get" "^2.0.0"
"@types/node" "^18.11.18"
Expand Down