Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Some themes fixes #3054

Merged
merged 4 commits into from
Sep 26, 2023
Merged

[Fix] Some themes fixes #3054

merged 4 commits into from
Sep 26, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Sep 17, 2023 •
edited
Loading

This PR fixes a few issues with some themes:

Most themes currently don't show the anticheat component with color:
image

Copy to clipboard in the new system info page is also invisible in Dracula and Old School:
image

Cyberspace has some dark stripes in the library:
image

Nord-Light has issues showing commands output in dialogs:
image

Fixes #2768

Also fixes:
Fixes #2993
Fixes #2552

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Sep 17, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team September 17, 2023 03:29
Etaash-mathamsetty
Etaash-mathamsetty approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

flavioislima
flavioislima approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good!

@flavioislima flavioislima merged commit 69f7412 into main Sep 26, 2023
13 checks passed
@flavioislima flavioislima deleted the themes-fixes branch September 26, 2023 17:11
@asmaloney asmaloney mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox tick is not in the center. Unreadable error messages Classic themes have invisible links
3 participants
@arielj @flavioislima @Etaash-mathamsetty