Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Cache installed wine version on prefix #4027

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

Snaggly
Copy link
Contributor

@Snaggly Snaggly commented Sep 24, 2024

This caches the used wine version to better detect a wine version change on the prefix. From 9.14 and onward, wineboot does not print the updated message on stdout, which breaks the update detection and eventually causes initial setups to never fire:
image

This will result in what what I reported in discord some time ago: Missing DOSBox config file for GOG games

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Sep 24, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Snaggly
Copy link
Contributor Author

Snaggly commented Sep 24, 2024

I have read the CLA Document and I hereby sign the CLA

src/backend/launcher.ts Outdated Show resolved Hide resolved
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@CommandMC CommandMC merged commit 5629445 into Heroic-Games-Launcher:main Nov 17, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants