Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Make auto install of known fixes not experimental anymore #4032

Merged
merged 1 commit into from
Nov 17, 2024
Merged

[UX] Make auto install of known fixes not experimental anymore #4032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion public/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,6 @@
"esync": "Enable Esync",
"exit-to-tray": "Exit to System Tray",
"experimental_features": {
"automaticWinetricksFixes": "Apply known fixes automatically",
"cometSupport": "Comet support",
"enableHelp": "Help component",
"enableNewDesign": "New design",
Expand Down
5 changes: 2 additions & 3 deletions src/backend/launcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,9 +369,8 @@ async function prepareWineLaunch(
if (runner === 'legendary') {
await legendarySetup(appName)
}
if (experimentalFeatures?.automaticWinetricksFixes !== false) {
await installFixes(appName, runner)
}

await installFixes(appName, runner)
}

try {
Expand Down
1 change: 0 additions & 1 deletion src/common/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ export type Release = {
export type ExperimentalFeatures = {
enableNewDesign: boolean
enableHelp: boolean
automaticWinetricksFixes: boolean
cometSupport: boolean
umuSupport: boolean
}
Expand Down
6 changes: 0 additions & 6 deletions src/frontend/screens/Settings/components/ExperimentalFeatures.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ const ExperimentalFeatures = () => {

const FEATURES = ['enableNewDesign', 'enableHelp', 'cometSupport']

if (platform !== 'win32') {
FEATURES.push('automaticWinetricksFixes')
}

if (platform === 'linux') {
FEATURES.push('umuSupport')
}
Expand All @@ -23,7 +19,6 @@ const ExperimentalFeatures = () => {
{
enableNewDesign: false,
enableHelp: false,
automaticWinetricksFixes: true,
cometSupport: true,
umuSupport: false
}
Expand All @@ -43,7 +38,6 @@ const ExperimentalFeatures = () => {
Translations:
t('setting.experimental_features.enableNewDesign', 'New design')
t('setting.experimental_features.enableHelp', 'Help component')
t('setting.experimental_features.automaticWinetricksFixes', 'Apply known fixes automatically')
t('setting.experimental_features.cometSupport', 'Comet support')
t('setting.experimental_features.umuSupport', 'Use UMU as Proton runtime')
*/
Expand Down
1 change: 0 additions & 1 deletion src/frontend/state/ContextProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ const initialContext: ContextType = {
experimentalFeatures: {
enableNewDesign: false,
enableHelp: false,
automaticWinetricksFixes: true,
cometSupport: true,
umuSupport: false
},
Expand Down
1 change: 0 additions & 1 deletion src/frontend/state/GlobalState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ class GlobalState extends PureComponent<Props> {
experimentalFeatures: {
enableNewDesign: false,
enableHelp: false,
automaticWinetricksFixes: true,
cometSupport: true,
umuSupport: false,
...(globalSettings?.experimentalFeatures || {})
Expand Down
Loading