Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ring from pkce and generator #85

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

thespooler
Copy link
Contributor

@thespooler thespooler commented Apr 13, 2020

This improves PR #84 by not including argonautica and only removing ring from pkce and generator.
Also includes changes discussed in #84.

@HeroicKatora HeroicKatora merged commit 3685e1a into HeroicKatora:next Apr 13, 2020
@thespooler
Copy link
Contributor Author

Also, this is a step towards #55

@thespooler thespooler deleted the unring-partial branch April 13, 2020 14:32
@Geobert
Copy link
Contributor

Geobert commented Apr 27, 2020

Hi,

is there a plan to backport the removal of ring in 0.4 branch?

I'd like to use oxide-auth in a production environment but ring version pulled by oxide-auth 0.4.5 (through actix-web 0.7) is clashing with the one pulled by warp 0.2

@HeroicKatora
Copy link
Owner

@Geobert There are no plans. Since the replacement also changed the algorithms used this would also be a breaking change in any case, or require more work than a simple backport.

@Geobert
Copy link
Contributor

Geobert commented Apr 27, 2020

Thank you for your answer!

I see. I'm looking forward to 0.5 then :D Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants