Skip to content

Commit

Permalink
Merge branch 'master' into issue#505
Browse files Browse the repository at this point in the history
  • Loading branch information
nabhajit-ray authored Jan 31, 2023
2 parents 82a5ca7 + 0ce26dd commit 405e11f
Show file tree
Hide file tree
Showing 3 changed files with 54 additions and 8 deletions.
43 changes: 41 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,53 @@ All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html)
# [v8.1.0-13]
### Notes
- This release supports API4600 minimally where we can use OneView v8.10 with this SDK.
- This release supports API4800 minimally where we can use OneView v8.10 with this SDK.
#### Major Changes

1. Removed Image Streamer support.

### Bug fixes & Enhancements:

- [#505](https://github.com/HewlettPackard/terraform-provider-oneview/issues/505) server profile changes for the management processor are not properly being handled
- [#507](https://github.com/HewlettPackard/terraform-provider-oneview/issues/507) Updates for OneView 6.6 LTS release?
- [#509](https://github.com/HewlettPackard/terraform-provider-oneview/issues/509) ilo settings updated not being commited into state

### Oneview Features supported
- Appliance SNMPv1 Trap Destinations
- Appliance SNMPv3 Trap Destinations
- Appliance SSH Access
- Appliance Time and Locale Configuration
- Connection Template
- Ethernet Network
- Enclosure
- Enclosure Group
- FC Network
- FCOE Network
- Firmware Drivers
- Hypervisor Manager
- Hypervisor Cluster Profile
- Id Pools Ipv4 Range
- Id Pools IPv4 Subnets
- Labels
- Interconnects
- Interconnect Types
- Logical Enclosure
- Logical Interconnects
- Logical Interconnect Groups
- Network Set
- Rack Manager
- Scope
- Server Certificate
- Server Hardware
- Server Hardware Type
- Server Profile
- Server Profile Template
- Storage Pool
- Storage Volume
- Storage Volume Attachments
- Storage Volume Template
- Storage System
- Uplink Set

### Oneview Features supported
- Appliance SNMPv1 Trap Destinations
- Appliance SNMPv3 Trap Destinations
Expand Down
15 changes: 11 additions & 4 deletions oneview/resource_logical_interconnect_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ func resourceLogicalInterconnectGroup() *schema.Resource {
},
"redundancy_type": {
Type: schema.TypeString,
Required: true,
Optional: true,
Default: nil,
},
"enclosure_indexes": {
Type: schema.TypeSet,
Expand Down Expand Up @@ -1720,7 +1721,11 @@ func resourceLogicalInterconnectGroupCreate(d *schema.ResourceData, meta interfa
portFlapSettingStructure.Description = utils.Nstring(portFlapSettingRawData["description"].(string))
portFlapSettingStructure.State = portFlapSettingRawData["state"].(string)
portFlapSettingStructure.Status = portFlapSettingRawData["status"].(string)
lig.PortFlapProtection = &portFlapSettingStructure
// if all of the values in the struct are empty, leave lig.PortFlapProtection nil
if portFlapSettingStructure != (ov.PortFlapProtection{}) {
lig.PortFlapProtection = &portFlapSettingStructure
}

}

if val, ok := d.GetOk("quality_of_service"); ok {
Expand Down Expand Up @@ -1868,7 +1873,6 @@ func resourceLogicalInterconnectGroupCreate(d *schema.ResourceData, meta interfa
}
lig.QosConfiguration = &ovQos
}

ligError := config.ovClient.CreateLogicalInterconnectGroup(lig)
d.SetId(d.Get("name").(string))
if ligError != nil {
Expand Down Expand Up @@ -3044,7 +3048,10 @@ func resourceLogicalInterconnectGroupUpdate(d *schema.ResourceData, meta interfa
PortFlapSetting.State = rawlval["state"].(string)
PortFlapSetting.Status = rawlval["status"].(string)
}
lig.PortFlapProtection = &PortFlapSetting

if PortFlapSetting != (ov.PortFlapProtection{}) {
lig.PortFlapProtection = &PortFlapSetting
}
if val, ok := d.GetOk("quality_of_service"); ok {
rawQoss := val.([]interface{})
ovQos := ov.QosConfiguration{}
Expand Down
4 changes: 2 additions & 2 deletions oneview/resource_server_profile_template.go
Original file line number Diff line number Diff line change
Expand Up @@ -2054,10 +2054,10 @@ func resourceServerProfileTemplateRead(d *schema.ResourceData, meta interface{})
if lp, ok := w["loginPriv"]; ok {
la["login_priv"] = lp
}
if hbcp, ok := w["hostBiosConfigPriv"]; ok {
if hbcp, ok := w["hostBIOSConfigPriv"]; ok {
la["host_bios_config_priv"] = hbcp
}
if hncp, ok := w["hostNicConfigPriv"]; ok {
if hncp, ok := w["hostNICConfigPriv"]; ok {
la["host_nic_config_priv"] = hncp
}
if hscp, ok := w["hostStorageConfigPriv"]; ok {
Expand Down

0 comments on commit 405e11f

Please sign in to comment.