Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss hipcms 1015 search suggestions for feature groups #806

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

melkishengue
Copy link
Member

@melkishengue melkishengue commented May 27, 2018

Note for the reviewer:

I made a mistake while commiting the changes. Besides displaying emails suggestions for feature toggles, this task also adds the functionality of saving the changes to the backend when the save button gets clicked (JIRA task 1016). So both functionalities have to be reviewed as part of these branch.

Copy link
Member

@rajatkhanna1994 rajatkhanna1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Melkis,

For task iss-hipcms-1015, the auth0ID is not listed in brackets next to the email address in the suggestions list.
And when I select a particular email address, the email address is entered in the respective feature group field. (that could be fine as it is more descriptive, but only if you're passing the auth0ID in the background).
A user only gets registered to a feature group through its auth0ID.
Could you please look into this?

…s-hipcms-1015-search-suggestions-for-feature-groups
…of github.com:HiP-App/HiP-CmsAngularApp into iss-hipcms-1015-search-suggestions-for-feature-groups

Just trying to commit things to the repo...
@melkishengue
Copy link
Member Author

Hey @rajatkhanna1994 ,
users can now be added resp. removed to resp from feature toggle groups. Unfortunately, I could not make the suggestion dropdown bigger in order to display the email in brackets, since these styles are generated and handled by angular. Email is displayed in brackets as wanted, but there is not enough space so that it can be read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants