Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boolean syntax helpers #309

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Add boolean syntax helpers #309

merged 3 commits into from
Oct 16, 2024

Conversation

JFriel
Copy link
Contributor

@JFriel JFriel commented Oct 16, 2024

Add syntax helpers for boolean values.

@JFriel JFriel requested a review from jas88 October 16, 2024 13:57
jas88
jas88 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@jas88 jas88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JFriel LGTM - I've added the new properties to IQueryHelper and added a unit test, plus moved the common case up to the common ancestor with just PG overriding, hope that's OK with you?

@JFriel
Copy link
Contributor Author

JFriel commented Oct 16, 2024

@JFriel LGTM - I've added the new properties to IQueryHelper and added a unit test, plus moved the common case up to the common ancestor with just PG overriding, hope that's OK with you?

Thanks for taking a look, all looks good

@jas88 jas88 merged commit 94de801 into main Oct 16, 2024
3 checks passed
@jas88 jas88 deleted the task/add-booleans-in-syntax-helper branch October 16, 2024 14:46
@rkm
Copy link

rkm commented Oct 16, 2024

Thanks James x2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jas88 jas88 jas88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JFriel @rkm @jas88