Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to build the package in normal catkin workspace #58

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

mqcmd196
Copy link
Contributor

@mqcmd196 mqcmd196 commented Feb 5, 2025

In my project, I want to make this package buildable in the catkin workspace. This PR enables it.

I should keep backward compatibility with Docker usage. I'll check whether it is workable with previous usage.

@mqcmd196
Copy link
Contributor Author

mqcmd196 commented Feb 5, 2025

@HiroIshida BTW, what lint command do you execute?

@mqcmd196
Copy link
Contributor Author

mqcmd196 commented Feb 5, 2025

I should keep backward compatibility with Docker usage. I'll check whether it is workable with previous usage.

Done

@mqcmd196
Copy link
Contributor Author

mqcmd196 commented Feb 5, 2025

ERROR: Could not install packages due to an EnvironmentError: [Errno 28] No space left on device: '/tmp/pip-unpacked-wheel-03z28diw/torch/lib/libtorch_cuda_cu.so' -> '/home/user/detic_ws/build/detic_ros/venv/lib/python3.8/site-packages/torch/lib/libtorch_cuda_cu.so'

🤮

@HiroIshida
Copy link
Owner

HiroIshida commented Feb 5, 2025

@mqcmd196

Thanks. That's really great change

BTW, what lint command do you execute?

I use mypy, isort and flake as listed here:
https://github.com/HiroIshida/detic_ros/blob/master/.github/workflows/peripheral.yml
mypy fails due to broken symbolic link. I'll fix this later, so could you comment out the mypy section in peripheral.yml and let the CI pass for now?

As for no-space-error left error, do you think adding option ARG to dockerfile so that it can skip the jsk_pcl_ros installation, may possibely reduce the volume usage significantly and fix this issue (if it has large dependencies)? Actually I recall that previously set this but it is not used

INSTALL_JSK_PCL=false

@mqcmd196
Copy link
Contributor Author

mqcmd196 commented Feb 5, 2025

I use mypy, isort and flake as listed here:
https://github.com/HiroIshida/detic_ros/blob/master/.github/workflows/peripheral.yml
mypy fails due to broken symbolic link. I'll fix this later, so could you comment out the mypy section in peripheral.yml and let the CI pass for now?

1784cfb

@mqcmd196 mqcmd196 force-pushed the catkin-virtualenv branch 2 times, most recently from 4ef7f89 to 6fc6e98 Compare February 5, 2025 14:14
@mqcmd196
Copy link
Contributor Author

mqcmd196 commented Feb 5, 2025

@HiroIshida

As for no-space-error left error, do you think adding option ARG to dockerfile so that it can skip the jsk_pcl_ros installation, may possibely reduce the volume usage significantly and fix this issue (if it has large dependencies)? Actually I recall that previously set this but it is not used

Before trying it, I added a slightly dirty patch (015e2b3 ). It seems that the test finished correctly.

I think we can make the docker image smaller using the small docker base image. In pip install torch==1.9.0+cu111 torchvision==0.10.0+cu111 torchaudio==0.9.0 part, cuda runtime is installed simultaneously. So, we can use the image here

@HiroIshida HiroIshida merged commit eb8fbbb into HiroIshida:master Feb 5, 2025
2 checks passed
@mqcmd196 mqcmd196 deleted the catkin-virtualenv branch February 5, 2025 14:41
@HiroIshida
Copy link
Owner

@mqcmd196 Thanks. I'll consider replacing it.

mqcmd196 added a commit to mqcmd196/detic_ros that referenced this pull request Feb 5, 2025
* Enabling catkin_virtualenv to build the package in normal catkin workspace

* restore docker usage

* fix cmake logic

* [format] isort

* temporary disable mypy test due to symlink submodules

* [CI] try cleaning up GA environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants