-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to build the package in normal catkin workspace #58
Conversation
@HiroIshida BTW, what lint command do you execute? |
Done |
🤮 |
Thanks. That's really great change
I use mypy, isort and flake as listed here: As for no-space-error left error, do you think adding option ARG to dockerfile so that it can skip the
|
|
4ef7f89
to
6fc6e98
Compare
6fc6e98
to
015e2b3
Compare
Before trying it, I added a slightly dirty patch (015e2b3 ). It seems that the test finished correctly. I think we can make the docker image smaller using the small docker base image. In |
@mqcmd196 Thanks. I'll consider replacing it. |
* Enabling catkin_virtualenv to build the package in normal catkin workspace * restore docker usage * fix cmake logic * [format] isort * temporary disable mypy test due to symlink submodules * [CI] try cleaning up GA environment
In my project, I want to make this package buildable in the catkin workspace. This PR enables it.
I should keep backward compatibility with Docker usage. I'll check whether it is workable with previous usage.