feature: add nix auth test #62
Conversation
There was a problem hiding this comment.
i'm happy you've brought on this code to work through!
first review pass. if in doubt with any of my comments fallback to anything that helps you get the tests pass on CI, specifically checks.x86_64-linux.auth-integration-nixos which was last run here: https://buildbot-nix-0.infra.holochain.org/#/builders/461
Co-authored-by: Stefan Junker <[email protected]>
Co-authored-by: Stefan Junker <[email protected]>
Co-authored-by: Stefan Junker <[email protected]>
Co-authored-by: Stefan Junker <[email protected]>
Co-authored-by: Stefan Junker <[email protected]>
Co-authored-by: Stefan Junker <[email protected]>
Co-authored-by: Stefan Junker <[email protected]>
…t into feature/nix-auth-test
| }; | ||
|
|
||
| config = lib.mkIf cfg.enable { | ||
| systemd.services.mongodb = { |
There was a problem hiding this comment.
assuming you want to enable the existing nixpkgs module for mondodb, please look at these: https://search.nixos.org/options?channel=24.11&from=0&size=50&sort=relevance&type=packages&query=services.mongodb
| systemd.services.mongodb = { | |
| services.mongodb = { |
| serviceConfig = { | ||
| LimitNOFILE = 500000; | ||
| } |
There was a problem hiding this comment.
and then these can't be in here with the others as this is indeed for systemd.services.mongodb. and is it really needed?
| systemd.services.mongodb = { | ||
| enable = true; | ||
| bind_ip = cfg.mongo.url; | ||
| documentation.enable = false; |
There was a problem hiding this comment.
this doesn't exist in the module linked above.
|
|
||
| after = [ | ||
| "network.target" | ||
| "holo-nats-server" |
There was a problem hiding this comment.
| "holo-nats-server" |
this is not a systemd service, just a nixos module. if NATS is spawned by the orchestrator it also won't show up as a separate systemd service, hence there's nothing NATS specific here at all.
| { ... }: | ||
| { | ||
| imports = [ | ||
| flake.nixosModules.holo-nats-server |
There was a problem hiding this comment.
this may not be needed depending on whether holo-orchestrator spawns NATS itself or not.
Co-authored-by: Stefan Junker <[email protected]>
No description provided.