63: Added some lightweight Nix state #81
Conversation
| // If we ever decide to enable `use-xdg-base-directories`, we'll need this to point to | ||
| // `$XDG_STATE_HOME/nix/channels` instead. | ||
| const NIX_CHANNELS_FILE: &str = "/root/.nix-channels"; | ||
| fn from_host() -> Self { |
There was a problem hiding this comment.
Could you add some tests for this?
There was a problem hiding this comment.
Sure. Did you have anything specific in mind? I can put some wrapper functions around the constant path name, have the test(s) create a dummy channel file and use this code to parse it if we think there's value there.
There was a problem hiding this comment.
Just some unit tests would be fine by me. Just anything to run through a happy path and validate it works as intended
There was a problem hiding this comment.
i propose the following as additions to this PR as they're lightweight enough IMO:
/root/.nix-defexpr/channels/holo-nixpkgs/.git-versionas a blob/var/lib/zerotier-one/identity.publicas a blob/etc/nixosas a compressed tarball. i expect this a few KB max. in my case it's 711B usingtar --dereference --hard-dereference -cavjf etcnixos.tbz2 /etc/nixos/*.nix- value of the NIX_PATH env var
- output of
systemctl status holo-nixpkgs-auto-upgrade.serviceor equivalent - output of
systemctl status auto-update.timeror equivalent
having these in a follow-up is fine with me.
i just think without these the requirements discussed in this issue aren't covered.
| // If we ever decide to enable `use-xdg-base-directories`, we'll need this to point to | ||
| // `$XDG_STATE_HOME/nix/channels` instead. | ||
| const NIX_CHANNELS_FILE: &str = "/root/.nix-channels"; | ||
| fn from_host() -> Self { |
There was a problem hiding this comment.
Just some unit tests would be fine by me. Just anything to run through a happy path and validate it works as intended
Closes #63. Some of the heavier-weight Nix-related stuff we want to check on will be added to self-checks infrastructure.