134: add inventory service tests #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olo-host into 134-add-inventory-test-suite
zeeshan595
requested changes
Mar 1, 2025
| use super::*; | ||
|
|
||
| #[tokio::test] | ||
| async fn test_handle_authenticated_inventory_update() -> Result<()> { |
There was a problem hiding this comment.
Can we rename the tests to this pattern
should_update_inventory_when_authenticated()
should_{action}_when_{state}
There was a problem hiding this comment.
I'm fine with that pattern, but we don't have any agreement about this yet and it is not a standard across this repo. I'm going to defer this particular request to another PR based on a team decision, as whatever pattern we decide on should be applied to all tests in this repo (and probably have a reciprocal pr in the holo-host-private).
zeeshan595
approved these changes
Mar 3, 2025
…ory service call; fix logs
* use macro * replace trait call fn with call macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134
NB: In the name of smaller PRs, I've separated out the tests from the main inventory PR. To review the inventory work itself, checkout out pr #86 .