Switch to BioStructures for PDB/structure rep #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BioStructures is poised to become the standard package for protein structure I/O and representation. While MIToS is retained for the MSA functionality and a few very useful data tables (vanderwaals radii and atom-level amino acid traits), otherwise this is a complete switch. It's somewhat surprising how few changes were needed to the tests (some of which were essentially cleanups that could have happened earlier).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BioStructures is poised to become the standard package for protein
structure I/O and representation. MIToS is retained for the MSA code
and a few extremely useful data tables (vanderwaals radii and
atom-level amino acid traits), but otherwise this is a complete switch. It's
somewhat surprising how few changes were needed to the tests (some of
which were essentially cleanups that could have happened earlier).
CC @jgreener64. @diegozea if you decide on a more thorough switch of MIToS internals some day, perhaps some of the changes here will be illustrative.