-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calibrite-profiler 1.3.3 #187392
calibrite-profiler 1.3.3 #187392
Conversation
cfb5dd6
to
7d21702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first-party download page links to the newest release on GitHub, so we can check that without having to worry about the pre-release issue. It's currently pointing to 1.3.3 despite it being "pre-release" on GitHub (as expected). I pushed a commit to update the livecheck
block accordingly.
I converted this to a draft until the related brew PR is done, so this won't get merged prematurely.
That works too! You can go ahead and rewrite history here to replace my original revert commit with yours if you like. With this change I guess we no longer depend on Homebrew/brew#18488, but there's a separate discussion going on over there anyway so they can be independent now. |
Upstream sometimes marks releases as "pre-release" on GitHub that are advertised on the first-party download page as the latest stable release, so we have to add this to `github_prerelease_allowlist.json`.
6070578
to
ab3877f
Compare
I'm not very knowledgeable about the prerelease allowlist behavior for casks but I updated this to use This works but our cask maintainers will have to confirm whether this is the appropriate way to handle this particular situation (i.e., allowing versions that are "pre-release" on GitHub, as we're tracking the first-party download page in the Normally I would say that we should ask upstream to not mark stable releases as "pre-release" if they're advertised as stable on the first-party download page but they haven't ever responded to issues in the GitHub repository, so it may not be worth the effort. |
Upstream sometimes marks a release as "pre-release" on GitHub but the first-party download page links to it as the latest stable version. This checks the download page, which links to the latest dmg file on GitHub without having to worry about latest/pre-release.
ab3877f
to
6e8bc46
Compare
Is the exception actually needed? From what I understand, it's only used for |
Yes, formulae/casks using a GitHub tag/release in the That audit doesn't interact with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Thanks!
Also add a comment to the cask to explain the original intent and prevent the same mistaken change from being made again.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Depends on Homebrew/brew#18488; there's no way currently to describe an exception as "prerelease or stable is fine" in
github_prerelease_allowlist.json
.