Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doggo 0.5.6 #137301

Closed
wants to merge 3 commits into from
Closed

doggo 0.5.6 #137301

wants to merge 3 commits into from

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jul 22, 2023

Bump to https://github.com/mr-karan/doggo/releases/tag/v0.5.6

Related:


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Jul 22, 2023
This was referenced Jul 22, 2023
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 22, 2023
@stefanb stefanb changed the title doggo 0.5.5 (buldable with Go 1.20 and 1.21) doggo 0.5.6 Jul 22, 2023
Formula/doggo.rb Outdated
Comment on lines 8 to 9
url "https://github.com/mr-karan/doggo/archive/refs/tags/v0.5.6.tar.gz"
sha256 "1965f4c909991bc38b65784ccbc03f4760214bca34f1bb984999f1fc8714ff96"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we no longer need the patches you can move these two lines to just below the homepage line above. You can then delete the stable block (since it will be empty).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx, done in f0f5395

carlocab
carlocab previously approved these changes Jul 22, 2023
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed carlocab’s stale review July 22, 2023 11:37

Replacement PR dispatched

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request superseded PR was replaced by another PR labels Jul 22, 2023
BrewTestBot pushed a commit that referenced this pull request Jul 22, 2023
* doggo 0.5.5 (buldable with Go 1.20 and 1.21)
  Related:
  * Patch from mr-karan/doggo#72
  * Similar to previous patch from mr-karan/doggo#66
  * Previous patch: https://github.com/Homebrew/homebrew-core/pull/122082/files#diff-5e4e01e1a59558e5fd034f3447ae40c220cd6bba96d0584ac1cd5038370ee77f
* Bump to 0.5.6
* Removed the stable do block

Closes #137301.

Signed-off-by: BrewTestBot <[email protected]>
@BrewTestBot BrewTestBot marked this pull request as draft July 22, 2023 11:37
@github-actions
Copy link
Contributor

✅ Replacement PR created at #137303.

@stefanb
Copy link
Member Author

stefanb commented Jul 22, 2023

@carlocab what is the reason for replacement PRs?
Would squashing and rebasing commits eliminate the need for replacement PRs?

github-merge-queue bot pushed a commit that referenced this pull request Jul 22, 2023
@stefanb stefanb deleted the doggo-go1.20 branch July 22, 2023 13:27
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue outdated PR was locked due to age superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants