Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ammonite-repl: switch to openjdk@17 #144278

Merged
merged 2 commits into from
Sep 20, 2023
Merged

ammonite-repl: switch to openjdk@17 #144278

merged 2 commits into from
Sep 20, 2023

Conversation

NicolasAlmerge
Copy link
Contributor

@NicolasAlmerge NicolasAlmerge commented Sep 20, 2023

Fixed the dependency issue that prevents the installation of openjdk 21 (#144045).

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. java Java use is a significant feature of the PR or issue labels Sep 20, 2023
@NicolasAlmerge NicolasAlmerge changed the title Update ammonite-repl.rb Update ammonite-repl.rb to fix a dependency issue Sep 20, 2023
@github-actions

This comment was marked as resolved.

@ZhongRuoyu ZhongRuoyu changed the title Update ammonite-repl.rb to fix a dependency issue ammonite-repl: switch to openjdk@17 Sep 20, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 20, 2023
@ZhongRuoyu
Copy link
Member

Thanks @NicolasAlmerge. I made some adjustments to your PR to address the test failure.

Regression seen in #144045, likely due to Scala not fully supporting JDK
21 (yet).

Co-authored-by: Ruoyu Zhong <[email protected]>
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 20, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 20, 2023
Merged via the queue into Homebrew:master with commit dce59cd Sep 20, 2023
This was referenced Sep 21, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. java Java use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants