-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
valgrind 3.13.0 #14653
valgrind 3.13.0 #14653
Conversation
The FTP URL comes from http://www.valgrind.org/downloads/current.html#current. http://valgrind.org/downloads/valgrind-3.13.0.tar.bz2, as one would expect from past URLs, is not available. |
So there is still a prayer of finishing #6408 before 10.13 is officially released. |
dshb alone will stop your attempt to take over the world with Sierra. |
37 installs in the last 30 days. Tempting … |
Please merge this. |
@amallia Of course it will be merged sooner or later... |
@zmwangx I am not a maintainer, even though I would be very happy to help maintaining it. I approved since i checked the changes and they look good for me. Sorry if this was confusing. |
Yeah, although technically GitHub allows you to do that, as I said approval from a non-maintainer is pointless (no offense). PRs (especially the green ones) are routinely merged here at maintainers' leisure. A "please merge this" comment doesn't expedite the process, except maybe on a neglected old PR, where a gentle bump might help. (I say this from the experience of a long term contributor and ex-maintainer.) |
Understand. I just thought two extra eyes could be good and wanted to signal that i checked. |
@zmwangx I see the ftp url on their site, but that does seem really weird. |
I opened this PR very soon after their release announcement. I assume they checked their download page before sending out the announcement, and I doubt they were hacked minutes after that. Anyway, I can send an email to the mailing list for confirmation if you want to be extra cautious. |
@ilovezfs sourceware.org should be legit IMO. Probably the old way of distributing it was BW consuming. If they got the the site hacked, they could have changed the packaged. EDIT: Dont forget that their repo is public: |
In any case, I'll wait for this to show up on some mirrors before proceeding. |
I sent an email to valgrind-users. Probably will show up in the archive later. https://sourceforge.net/p/valgrind/mailman/valgrind-users/?style=threaded Update. Here it is: https://sourceforge.net/p/valgrind/mailman/message/35897473/ |
Poifect. |
By the way RC1 were hosted at sourceware.org too. See https://sourceforge.net/p/valgrind/mailman/message/35879348/. |
Got a reply from one of the developers:
https://sourceforge.net/p/valgrind/mailman/message/35897582/ |
Perhaps they just haven't heard of GitHub yet. |
Should I send another email informing them of GitHub and GitLab? |
That would be quite amusing. |
🎆 🎇 💎 |
@zmwangx while you're at it, you could mention the existence of sha256 since they're still posting md5. |
I gently reminded them that MD5 was cracked more than a decade ago. (Though I forgot at the moment that a practical preimage attack on MD5 was yet to be found.) |
Created with
brew bump-formula-pr
.🇹🇹