Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valgrind 3.13.0 #14653

Closed
wants to merge 1 commit into from
Closed

valgrind 3.13.0 #14653

wants to merge 1 commit into from

Conversation

zmwangx
Copy link
Contributor

@zmwangx zmwangx commented Jun 16, 2017

Created with brew bump-formula-pr.


🇹🇹

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

The FTP URL comes from http://www.valgrind.org/downloads/current.html#current. http://valgrind.org/downloads/valgrind-3.13.0.tar.bz2, as one would expect from past URLs, is not available.

@ilovezfs
Copy link
Contributor

So there is still a prayer of finishing #6408 before 10.13 is officially released.

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

dshb alone will stop your attempt to take over the world with Sierra.

@ilovezfs
Copy link
Contributor

37 installs in the last 30 days. Tempting …

@amallia
Copy link

amallia commented Jun 16, 2017

Please merge this.

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

@amallia Of course it will be merged sooner or later...
Are you a new maintainer? If not, please don't abuse the approval feature; it's pointless and confusing...

@amallia
Copy link

amallia commented Jun 16, 2017

@zmwangx I am not a maintainer, even though I would be very happy to help maintaining it.

I approved since i checked the changes and they look good for me. Sorry if this was confusing.

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

I approved since i checked the changes and they look good for me.

Yeah, although technically GitHub allows you to do that, as I said approval from a non-maintainer is pointless (no offense). PRs (especially the green ones) are routinely merged here at maintainers' leisure. A "please merge this" comment doesn't expedite the process, except maybe on a neglected old PR, where a gentle bump might help. (I say this from the experience of a long term contributor and ex-maintainer.)

@amallia
Copy link

amallia commented Jun 16, 2017

Understand. I just thought two extra eyes could be good and wanted to signal that i checked.

@ilovezfs
Copy link
Contributor

@zmwangx I see the ftp url on their site, but that does seem really weird.

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

I opened this PR very soon after their release announcement. I assume they checked their download page before sending out the announcement, and I doubt they were hacked minutes after that. Anyway, I can send an email to the mailing list for confirmation if you want to be extra cautious.

@amallia
Copy link

amallia commented Jun 16, 2017

@ilovezfs sourceware.org should be legit IMO. Probably the old way of distributing it was BW consuming. If they got the the site hacked, they could have changed the packaged.

EDIT: Dont forget that their repo is public: svn co svn://svn.valgrind.org/valgrind/trunk valgrind

@ilovezfs
Copy link
Contributor

In any case, I'll wait for this to show up on some mirrors before proceeding.

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

I sent an email to valgrind-users. Probably will show up in the archive later. https://sourceforge.net/p/valgrind/mailman/valgrind-users/?style=threaded

Update. Here it is: https://sourceforge.net/p/valgrind/mailman/message/35897473/

@ilovezfs
Copy link
Contributor

Poifect.

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

By the way RC1 were hosted at sourceware.org too. See https://sourceforge.net/p/valgrind/mailman/message/35879348/.

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

Got a reply from one of the developers:

According to the download page
http://www.valgrind.org/downloads/current.html, the tarball of the 3.13.0 is
hosted at sourceware.org
(ftp://sourceware.org/pub/valgrind/valgrind-3.13.0.tar.bz2). Is this legit?
Just want to make sure, because releases up until 3.12.0 were all hosted
directly on valgrind.org.

Yes it is. We will also soon move the code repository from subversion on
svn.valgrind.org to git on sourceware. Website will most likely stay on
valgrind.org and the bug tracker on bugs.kde.org.

https://sourceforge.net/p/valgrind/mailman/message/35897582/

@ilovezfs
Copy link
Contributor

Perhaps they just haven't heard of GitHub yet. :trollface:

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

Should I send another email informing them of GitHub and GitLab? :trollface:

@ilovezfs ilovezfs closed this in 35244df Jun 16, 2017
@zmwangx zmwangx deleted the valgrind-3.13.0 branch June 16, 2017 13:20
@ilovezfs
Copy link
Contributor

Should I send another email informing them of GitHub and GitLab?

That would be quite amusing.

@ilovezfs
Copy link
Contributor

🎆 🎇 💎

@ilovezfs
Copy link
Contributor

@zmwangx while you're at it, you could mention the existence of sha256 since they're still posting md5.

@zmwangx
Copy link
Contributor Author

zmwangx commented Jun 16, 2017

I gently reminded them that MD5 was cracked more than a decade ago. (Though I forgot at the moment that a practical preimage attack on MD5 was yet to be found.)

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants