Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libunistring 1.3 #194691

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

libunistring 1.3 #194691

wants to merge 2 commits into from
+14 −10

Conversation

chenrui333
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` long dependent tests Set a long timeout for dependent testing labels Oct 16, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Oct 16, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Oct 16, 2024
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 17, 2024
@carlocab carlocab added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Oct 17, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 17, 2024
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 17, 2024
@carlocab
Copy link
Member

After downloading the built bottles here, running brew test guile fails. However, running the commands from the guile test manually succeeds, which is weird.

@Bo98 any ideas?

@carlocab carlocab added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. and removed long dependent tests Set a long timeout for dependent testing labels Oct 18, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request long dependent tests Set a long timeout for dependent testing labels Oct 18, 2024
@carlocab
Copy link
Member

Hmm, I see. The Sequoia builds are missing -liconv for some reason. Weird.

@Bo98
Copy link
Member

Bo98 commented Oct 18, 2024

Can have a look further at some point in the weekend but we should probably have a test for iconv support in libunistring directly.

@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 18, 2024
@carlocab
Copy link
Member

Probably at least in part covered by make check, but we skip it now for newer macOS.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 18, 2024
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 18, 2024
@Bo98
Copy link
Member

Bo98 commented Oct 18, 2024 •
edited
Loading

Ahh this explains why it only happens on macOS 15: https://github.com/Homebrew/brew/blob/6f17b0644771e0a1d7c15ac72471dae2ef87314a/Library/Homebrew/extend/os/mac/extend/ENV/super.rb#L137.

Upstream have decided to no longer allow macOS iconv: coreutils/gnulib@bab1308 & https://savannah.gnu.org/bugs/?65686

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 18, 2024
@carlocab carlocab removed the CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. label Oct 18, 2024
@carlocab carlocab added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner long dependent tests Set a long timeout for dependent testing CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner and removed automerge-skip `brew pr-automerge` will skip this pull request long dependent tests Set a long timeout for dependent testing CI-linux-self-hosted Build on Linux self-hosted runner labels Oct 18, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 18, 2024
@Bo98
Copy link
Member

Bo98 commented Oct 18, 2024

Seems very messy if it bleeds into gettext.

It has to be said, the situation has been like this for an entire year and precisely zero people appear to have noticed or complained.

@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Oct 21, 2024
@carlocab carlocab removed the stale No recent activity label Oct 21, 2024
@carlocab
Copy link
Member

Bleeding into gettext is kinda inevitable. But this was just an experiment to see how testing went -- will change this to use am_cv_func_iconv_works instead.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 21, 2024
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 21, 2024
chenrui333 and others added 2 commits October 21, 2024 20:00
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 21, 2024
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 21, 2024
@carlocab
Copy link
Member

It has to be said, the situation has been like this for an entire year and precisely zero people appear to have noticed or complained.

Note: it is not quite the case that precisely zero people have noticed or complained: #142490 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
autobump bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long dependent tests Set a long timeout for dependent testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @carlocab @Bo98