Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdocs-material 9.5.41 (new formula) #194840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clintonsteiner
Copy link

  • [ x ] Have you followed the guidelines for contributing?
  • [ x ] Have you ensured that your commits follow the commit style guide?
  • [ x ] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ x ] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ x ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ x ] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 18, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@gromgit
Copy link
Member

gromgit commented Oct 18, 2024

Is this a Material Design library for mkdocs? If so, this should probably depends_on "mkdocs", and have a test similar to the one in mkdocs.

If it's a drop-in replacement for mkdocs (as the docs seem to suggest), then again, a similar test to mkdocs seems warranted, and a conflicts_with clause should probably be added.

@clintonsteiner
Copy link
Author

This is a design library for mkdocs @gromgit

@clintonsteiner
Copy link
Author

Changed to take pr comments, thanks @gromgit

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 18, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 18, 2024
Comment on lines +154 to +156
Language::Python.each_python(build) do |python, _|
system python, "-c", "import material"
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this?

Suggested change
Language::Python.each_python(build) do |python, _|
system python, "-c", "import material"
end
system "python3.13", "-c", "import material"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenrui333 this caused the linux ci test to stop failing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if there's a different way this should be resolved

@gromgit
Copy link
Member

gromgit commented Oct 21, 2024

Is there a reason this formula doesn't use a similar test to the mkdocs formula, given that it's a library for the latter rather than just a general-purpose Python library?

@clintonsteiner
Copy link
Author

I don't want to create a test as intense as creating a site with the theme and instead would prefer to use a test that makes sure its available

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 21, 2024
@clintonsteiner clintonsteiner force-pushed the mkdocs-material branch 2 times, most recently from 338073e to 73e6654 Compare October 21, 2024 19:19
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 21, 2024
@clintonsteiner
Copy link
Author

@chenrui333 let me know how I can fix this up enough to be committed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants